Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #10260

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Upgrade dependencies #10260

merged 1 commit into from
Jul 5, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jul 4, 2019

I checked the Webpack release notes for the upgrade included below. (There didn't seem to be anything surprising.)

@jryans jryans requested a review from a team July 4, 2019 14:17
turt2live
turt2live requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the package.json as well with the latest versions we're using. This saves some steps when investigating which versions of things we're using.

Otherwise lgtm - it's a lockfile change with no obvious steal-my-keys packages.

@jryans jryans requested a review from turt2live July 5, 2019 16:05
@jryans
Copy link
Collaborator Author

jryans commented Jul 5, 2019

The PR is the result of running yarn upgrade, which doesn't appear to touch package.json. I then tried yarn upgrade-interactive and syncyarnlock, but neither did the right thing. 😭

turt2live
turt2live approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in #riot-dev, we should just merge this because it's difficult to update the package.json for now

@jryans jryans merged commit cb92e1d into develop Jul 5, 2019
@t3chguy t3chguy deleted the jryans/upgrade-deps branch May 12, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jryans @turt2live