Centralize control over Range headers in the range VDP #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative approach to the ideas recorded in varnishcache#3251: By centralizing control over the Range-Request related headers, range handling can be disabled by removing the range vdp from the response filters. By default, we now always push the range VDP as long as http_range_support is on. If that is the case, behaviour is just the same as before, but the Accept-Ranges response header is now set in the range VDP's init callback. The difference is that, if the range vdp is removed from the filters, no Accept-Ranges header will be sent. Note that if the range will not be active during delivery if it only sets Accept-Ranges (by returning 1 from the init callback). Fixes varnishcache#3251
|
This is a Firm no. See #3251 for full comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to the ideas recorded in #3251: By centralizing control over the range-request related headers, range handling can be disabled by removing the
rangevdp from the response filters.By default, we now always push the
rangeVDP as long ashttp_range_supportis on. If that is the case, behaviour is just the same as before, but theAccept-Rangesresponse header is now set in the range VDP's init callback.The difference is that, if the range vdp is removed from the filters, no
Accept-Rangesheader will be sent.Note that the
rangevdp will not be active during body delivery if it only setsAccept-Ranges(by returning 1 from the init callback).Fixes #3251