Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server-side h2c support #1778

Closed
wants to merge 4 commits into from
Closed

add server-side h2c support #1778

wants to merge 4 commits into from

Conversation

lucifer9
Copy link
Contributor

When v2ray (using h2 transport) and the reverse proxy are on the same machine, maybe there is no need to use TLS between v2ray and the reverse proxy. #1644

@kslr kslr requested a review from xiaokangwang June 27, 2019 08:42
Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pull request is ready to be merged.

We needs to add this change into the change log and update documents accordingly.

@eycorsican
Copy link
Contributor

看起来代码有点重复了?if/else 里 assign 不同的 server 应该就可以,这是个小的更改,建议 force push 到一个 commit 里。

@xiaokangwang
Copy link
Contributor

我同意 @eycorsican 的观点。

@lucifer9 , 你是否想按照 @eycorsican 所建议的,将多个commit合并为一个,并通过if/else assign 不同的server来提高代码复用程度呢? 如果你不愿意的话可以由我来写这部分的代码。

@lucifer9
Copy link
Contributor Author

lucifer9 commented Jul 5, 2019

@xiaokangwang
no problem.
I can do as @eycorsican said.
I'll close this PR first.

@lucifer9 lucifer9 closed this Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants