Skip to content

Commit

Permalink
fix #7321
Browse files Browse the repository at this point in the history
  • Loading branch information
@mapx-
mapx- committed May 7, 2020
1 parent 60ce613 commit 8fd12b0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions filters/filters.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5088,9 +5088,9 @@ sourceforge.net##+js(nano-stb)
! /~https://github.com/uBlockOrigin/uAssets/issues/4687
! /~https://github.com/uBlockOrigin/uAssets/issues/4711
! /~https://github.com/uBlockOrigin/uAssets/issues/5919
!twitter.com##article:has-text(/Promoted|Gesponsert|Реклама|Promocionado|Sponsorisé|Uitgelicht/):xpath(../..)
twitter.com##:xpath(//span[(text()='Promoted' or text()='Gesponsert' or text()='Реклама' or text()='Promocionado' or text()='Sponsorisé' or text()='Uitgelicht' or text()='推荐')]/../../../../..)
twitter.com##[data-testid="trend"]:has-text(/推荐|Promoted|Gesponsert|Реклама|Promocionado|Sponsorisé|Uitgelicht/):xpath(..)
!twitter.com##:xpath(//span[(text()='Promoted' or text()='Gesponsert' or text()='Реклама' or text()='Promocionado' or text()='Sponsorisé' or text()='Uitgelicht' or text()='推荐')]/../../../../..)
twitter.com##[data-testid="trend"]:has-text(/推荐|Promoted|Gesponsert|Реклама|Promocionado|Sponsorisé|Uitgelicht|プロモーション/):upward(1)
twitter.com##span:has-text(/^推荐|Promoted|Gesponsert|Реклама|Promocionado|Sponsorisé|Uitgelicht|プロモーション$/):upward(5)

! https://forums.lanik.us/viewtopic.php?f=62&t=40228#p133884
popularmechanics.com##+js(nostif, addEventListener, 0)
Expand Down

4 comments on commit 8fd12b0

@gorhill
Copy link
Member

@gorhill gorhill commented on 8fd12b0 May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people are reporting some sort of Twitter breakage on Reddit, so I found this Twitter-related commit and I wonder if this could be the cause: https://www.reddit.com/r/uBlockOrigin/comments/gflpku/did_something_just_change_that_makes_ubo_screw/.

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 8fd12b0 May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, re-enabled the xpath filter

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 8fd12b0 May 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

370565f

@gorhill
Copy link
Member

@gorhill gorhill commented on 8fd12b0 May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A filter such as ##span:has-text(...) is too broad, the first part, ##span returns over 270 elements on my side. We need to reduce as much as possible the number of elements before chaining to a procedural operator. We need to use whatever stable DOM info can be used to narrow as much as possible. For example, ##[data-testid="trend"] span returns 29 elements.

Please sign in to comment.