Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain.fromSeq vs NonEmptyChain.fromSeq #2718

Closed
dcastro opened this issue Feb 1, 2019 · 1 comment
Closed

Chain.fromSeq vs NonEmptyChain.fromSeq #2718

dcastro opened this issue Feb 1, 2019 · 1 comment
Labels
Source Breaking

Comments

@dcastro
Copy link
Contributor

dcastro commented Feb 1, 2019 •
edited
Loading

There seems to be an inconsistency between these two methods.

Chain.fromSeq takes a scala.collection.Seq, whereas NonEmptyChain.fromSeq takes a scala.collection.immutable.Seq.

I assume the correct fix is to change Chain.fromSeq to take an immutable sequence, but that sounds like a breaking change...

Cats version: 1.6.0.
@gheine gheine mentioned this issue Mar 25, 2019
Closed
@travisbrown travisbrown mentioned this issue Nov 8, 2019
Merged
@diesalbla
Copy link
Contributor

This seems to have been solved, or at least worked around, in #3133 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Source Breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rossabaker @dcastro @diesalbla @LukaJCB