feat(e2e): Migrated e2e tests for metadata providers api errors #16443
Conversation
HajekOndrej
force-pushed
the
migrate-metadata-tests
branch
3 times, most recently
from
7ba04e9 to
1f0468f
Compare
HajekOndrej
force-pushed
the
migrate-metadata-tests
branch
from
1f0468f to
7c0e54b
Compare
| @@ -1,5 +1,6 @@ | |||
| import { Page } from '@playwright/test'; | |||
|
|
|||
| import * as metadataUtils from '@trezor/suite/src/utils/suite/metadata'; | |||
There was a problem hiding this comment.
let's do focus importing
| import * as metadataUtils from '@trezor/suite/src/utils/suite/metadata'; | |
| import { encrypt } from '@trezor/suite/src/utils/suite/metadata'; |
| @@ -77,11 +78,30 @@ export class MetadataProviderMock { | |||
| } | |||
|
|
|||
| @step() | |||
| stop() { | |||
| setNextResponse(response: Record<string, any>): void { | |||
| if (!this.providerMock) { | |||
| throw new Error('Provider mock not initialized'); | |||
There was a problem hiding this comment.
Let's DRY this if (!this.providerMock) block by introducing a getter that will do the assertion and throw :)
| await onboardingPage.completeOnboarding(); | ||
| await dashboardPage.discoveryShouldFinish(); | ||
|
|
||
| await settingsPage.navigateTo('application'); | ||
| await settingsPage.metadataSwitch.click(); |
There was a problem hiding this comment.
Potential to DRY these steps to before each.
not sure before which steps metadataProviderMock.setFileContent needs to be set tho ...
packages/suite-desktop-core/e2e/tests/metadata/dropbox-api-errors.test.ts
Show resolved
Hide resolved
| await metadataPage.metadataInput.fill('Kvooo'); | ||
| await page.keyboard.press('Enter'); | ||
|
|
||
| // Validate the error message in the toast notification | ||
| await expect(page.getByTestId('@toast/error')).toHaveText( | ||
| 'Error: Failed to save labeling data: Error in call to API function "files/upload": The given OAuth 2 access token is malformed.', | ||
| ); |
There was a problem hiding this comment.
Can we add a validation that the label has still the original text?
await expect(metadataPage.accountLabel(AccountLabelId.BitcoinDefault1)).toHaveText('<original name>')
| metadataProviderMock.setNextResponse({ | ||
| status: 200, | ||
| body: { | ||
| name: { | ||
| given_name: 'dog', | ||
| surname: 'cat', | ||
| familiar_name: 'kitty-dog', | ||
| display_name: 'dog-cat', | ||
| abbreviated_name: 'DC', | ||
| }, | ||
| email: 'some@mail.com', | ||
| email_verified: true, | ||
| profile_photo_url: 'foo', | ||
| disabled: false, | ||
| country: 'CZ', | ||
| locale: 'en', | ||
| referral_link: 'foo', | ||
| is_paired: false, | ||
| }, | ||
| }); | ||
|
|
||
| metadataProviderMock.setNextResponse({ | ||
| status: 429, | ||
| body: 'Rate limited!', | ||
| headers: { | ||
| 'Content-Type': 'text/plain; charset=utf-8', | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I dont understand this part. Can we have a short call so I could get the context
I dont get the order of those two. Responses are served as FIFO
I found similar object in packages/e2e-utils/src/mocks/dropbox.ts:77:
// https://api.dropboxapi.com/2/users/get_current_account
app.post('/2/users/get_current_account', (_req, res) => {
const user = {
name: {
given_name: 'dog',
surname: 'cat',
familiar_name: 'kitty-dog',
display_name: 'dog-cat',
abbreviated_name: 'DC',
},
email: 'some@mail.com',
email_verified: true,
profile_photo_url: 'foo',
disabled: false,
country: 'CZ',
locale: 'en',
referral_link: 'foo',
is_paired: false,
};
| await page.getByTestId('@account-menu/btc/normal/0').click(); | ||
| await metadataPage.editLabel(AccountLabelId.BitcoinDefault1, 'Kvooo'); | ||
| }); |
There was a problem hiding this comment.
Test does not have any verification of success of that the initial try failed and succeded on retry (not sure that info about retring is vibisble)
There was a problem hiding this comment.
await expect(metadataPage.accountLabel(AccountLabelId.BitcoinDefault1)).toHaveText('Kvooo')
| await metadataPage.editLabel(AccountLabelId.BitcoinDefault1, 'Kvooo'); | ||
| }); | ||
|
|
||
| test('Incomplete data returned from provider', async ({ |
There was a problem hiding this comment.
I dont understand the impact of 'incomplete data' on suite and what should happen and what shouldn't.
Like should the rename fail? or is it just that the comunication is retried and does not fall apartt.
Maybe this is a candidate for the later refactoring. I have feeling that we miss some verifications here
There was a problem hiding this comment.
From my understanding of the original test, the ability to rename the label after the incomplete data is sent is the verification
Description
Migrated tests for metadata provider API errors
Related Issue
Resolve
Screenshots: