-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spread over Object.assign #193
Conversation
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 22 22
Lines 847 847
Branches 219 219
=======================================
Hits 755 755
Misses 70 70
Partials 22 22
Continue to review full report at Codecov.
|
Actually, babel includes Object.assign polyfill for object spread. |
@thangngoc89 it includes it for spread, but if you directly use Object.assign, then the user library will need to add polyfill. |
@thangngoc89 he has a point. |
Thank you so much for accepting the PR ! I feel I didn't quite explain myself well. Either way, kudos to Emotion for being awesome ! |
Yeah. I didn't think about manually providing Object.assign polyfill |
@thangngoc89 Sorry for the rush, but when can I expect this patch to get released to npm ? Thanks! |
What: Object.assign is being replaced by Object spread syntax.
Why: Object spread doesn't require you to also include polyfill for Object.assign, hence it's better for users trying it out on older browsers.
Checklist: