Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IntelFrameworkModulePkg/Pci/IdeBusDxe (Bugzilla Bug 1339) #7639

Closed
tianocore-issues opened this issue Nov 20, 2018 · 6 comments
Closed
Labels
package:intelframeworkmodulepkg priority:medium Moderate impact. Should be prioritized over lower priority issues. type:bug Something isn't working

Comments

@tianocore-issues
Copy link

This issue was created automatically with bugzilla2github

Bugzilla Bug 1339

Date: 2018-11-20T01:13:27+00:00
From: @niruiyu
To: @niruiyu
CC: hao.a.wu, @lersek, yonghong.zhu

Last updated: 2019-07-03T01:49:10+00:00

@tianocore-issues
Copy link
Author

Comment 5641

Date: 2018-11-20 01:13:27 +0000
From: @niruiyu

  • Industry Specification: ---
  • Releases to Fix: EDK II Master
  • Target OS: ---
  • Bugzilla Assignee(s): @niruiyu

It's not used by any platform.
AHCI is very popular now. So IdeBusDxe is no longer needed in new platforms.

@tianocore-issues
Copy link
Author

Comment 5650

Date: 2018-11-20 04:03:43 +0000
From: @lersek

Hi Ray,

I don't object to removing IdeBusDxe. However, we should be clearler why we can do that.

We can remove IdeBusDxe because the replacement driver stack (see below) is backward compatible, and it supports IDE.

The replacement driver stack consists of:

  • a platform-dependent EFI_IDE_CONTROLLER_INIT_PROTOCOL implementation
    (although nowadays a central one exists too,
    MdeModulePkg/Bus/Pci/SataControllerDxe)

  • MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf

  • MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf

(See for example commit b82802b, "OvmfPkg: enable SATA controller", 2015-09-22.)

Old (possibly virtual) platforms will still require IDE support for a while (such as the "pc" machine type of QEMU), but thankfully, the above modern driver stack offers that as well.

Thanks!

@tianocore-issues
Copy link
Author

Comment 5651

Date: 2018-11-20 04:11:47 +0000
From: @niruiyu

Laszlo,
Thanks for your comments. I agree the replacement driver stack should be provided here and in final commit message.

@tianocore-issues
Copy link
Author

Comment 6427

Date: 2019-02-20 00:03:46 +0000
From: Yonghong Zhu <<yonghong.zhu>>

Offline Bug scrub: Assign to module owner

@tianocore-issues
Copy link
Author

Comment 7407

Date: 2019-05-07 19:55:06 +0000
From: Yonghong Zhu <<yonghong.zhu>>

Per edk2-stable201908 planning to update the deadline info.

@tianocore-issues
Copy link
Author

Comment 8349

Date: 2019-07-03 01:49:10 +0000
From: Hao Wu <<hao.a.wu>>

Resolved via commit:

aa7fc1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intelframeworkmodulepkg priority:medium Moderate impact. Should be prioritized over lower priority issues. type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant