Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Fix typos in German translation for docs/de/docs/features.md #4533

Merged
merged 4 commits into from
Aug 22, 2022
Merged

🌐 Fix typos in German translation for docs/de/docs/features.md #4533

merged 4 commits into from
Aug 22, 2022

Conversation

0xflotus
Copy link
Contributor

@0xflotus 0xflotus commented Feb 7, 2022 •
edited
Loading

I fixed some small errors in the german translation of features.md

rogerbrinkmann
rogerbrinkmann approved these changes Feb 7, 2022
View reviewed changes
Copy link

@rogerbrinkmann rogerbrinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, they are correct and necessary.

@rogerbrinkmann
Copy link

@0xflotus, thank's for you work. Let's keep it rolling. Just recently I added two new translations. #4517 and #4520. Maybe, if you can spare the time, you could return the favour and review them.

@tiangolo tiangolo changed the title docs: fixed some grammar errors in german translation 🌐 Fix typos in German translation for docs/de/docs/features.md May 10, 2022
@tiangolo tiangolo added lang-all Translations awaiting-review lang-de German translations labels May 10, 2022
@github-actions github-actions bot mentioned this pull request May 10, 2022
Closed
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #4533 (10f7bc3) into master (7953353) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4533   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          533       533           
  Lines        13725     13725           
=========================================
  Hits         13725     13725

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0e7231f at: https://6279dfda5674f8250d1aab9a--fastapi.netlify.app

iron3oxide
iron3oxide approved these changes Aug 18, 2022
View reviewed changes
Copy link

@iron3oxide iron3oxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't spot any change I wouldn't agree with.

@tiangolo
Copy link
Member

Great, thank you @0xflotus! 🚀

And thanks for the reviews @rogerbrinkmann and @iron3oxide 🍰

@tiangolo tiangolo enabled auto-merge (squash) August 22, 2022 14:54
@tiangolo tiangolo merged commit 1ff8df6 into fastapi:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerbrinkmann rogerbrinkmann rogerbrinkmann approved these changes

@iron3oxide iron3oxide iron3oxide approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-de German translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xflotus @rogerbrinkmann @tiangolo @iron3oxide