Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NuGet publish #48

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Fix NuGet publish #48

merged 1 commit into from
Dec 26, 2021

Conversation

Windows10CE
Copy link
Member

The GITHUB_REF_NAME environment variable didn't have the tag as expected, so this switches to using the same action to get the tag as the release workflow

@PhantomGamers
Copy link

mmm I thought GITHUB_REF_NAME was supposed to work as well so I didn't say anything before but github.ref_name definitely has the tag name

I use that here: /~https://github.com/PhantomGamers/SUWSF/blob/main/.github/workflows/publish.yaml#L19

@Windows10CE
Copy link
Member Author

Actually fixed now, GitHub Actions uses the action files from the actual release tag, not from master, so it took me a bit longer than I would like to admit to figure out that github.ref_name actually worked

Copy link
Member

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work 👍

@MythicManiac MythicManiac merged commit e403656 into master Dec 26, 2021
@MythicManiac MythicManiac deleted the fix-nuget-publish branch December 26, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants