fix(vectors): update arg types

thi-ng · Jun 9, 2019 · 6d213bd · 6d213bd
1 parent b79d0c6
commit 6d213bd
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/packages/vectors/src/jitter.ts b/packages/vectors/src/jitter.ts
@@ -4,7 +4,7 @@ import { ReadonlyVec, Vec } from "./api";
 import { randNorm } from "./random";
 
 export const jitter = (
-    out: Vec,
+    out: Vec | null,
     a: ReadonlyVec,
     n = 1,
     rnd: IRandom = SYSTEM

diff --git a/packages/vectors/src/normalize.ts b/packages/vectors/src/normalize.ts
@@ -1,5 +1,5 @@
 import { EPS } from "@thi.ng/math";
-import { Vec, VecOpVO } from "./api";
+import { VecOpVO } from "./api";
 import { mag } from "./mag";
 import { mulN } from "./muln";
 import { set } from "./set";
@@ -12,7 +12,7 @@ import { set } from "./set";
  * @param v
  * @param n
  */
-export const normalize: VecOpVO<number> = (out: Vec | null, v: Vec, n = 1) => {
+export const normalize: VecOpVO<number> = (out, v, n = 1) => {
     !out && (out = v);
     const m = mag(v);
     return m >= EPS ? mulN(out, v, n / m) : out !== v ? set(out, v) : out;

diff --git a/packages/vectors/src/ortho-normal.ts b/packages/vectors/src/ortho-normal.ts
@@ -1,16 +1,16 @@
+import { ReadonlyVec, Vec } from "./api";
 import { cross3 } from "./cross";
-import { sub3 } from "./sub";
 import { normalize } from "./normalize";
-import { Vec, ReadonlyVec } from "./api";
+import { sub3 } from "./sub";
 
 /**
  * Produces a vector which is perpendicular/normal to the plane spanned
  * by given 3 input vectors. If `normalize` is true (default), the
  * result vector will be normalized.
  *
  * ```
- * orthoNormal3([], [0,0,0], [1,0,0], [0,1,0])
- * // [0,0,1]
+ * orthoNormal3([], [0, 0, 0], [1, 0, 0], [0, 1, 0])
+ * // [0, 0, 1]
  * ```
  *
  * @param out
@@ -20,7 +20,7 @@ import { Vec, ReadonlyVec } from "./api";
  * @param normalize
  */
 export const orthoNormal3 = (
-    out: Vec,
+    out: Vec | null,
     a: ReadonlyVec,
     b: ReadonlyVec,
     c: ReadonlyVec,

diff --git a/packages/vectors/src/random.ts b/packages/vectors/src/random.ts
@@ -1,5 +1,10 @@
 import { IRandom, SYSTEM } from "@thi.ng/random";
-import { MultiVecOpOOO, ReadonlyVec, Vec, VecOpOOO } from "./api";
+import {
+    MultiVecOpOOO,
+    ReadonlyVec,
+    Vec,
+    VecOpOOO
+} from "./api";
 import { defHofOp } from "./internal/codegen";
 import { normalize } from "./normalize";
 
@@ -33,7 +38,7 @@ export const [random, random2, random3, random4] = defHofOp<
  * @param n
  * @param rnd
  */
-export const randNorm = (v: Vec, n = 1, rnd: IRandom = SYSTEM) => {
+export const randNorm = (v: Vec | null, n = 1, rnd: IRandom = SYSTEM) => {
     v = random(v, -1, 1, rnd);
     return normalize(v, v, n);
 };