Skip to content

Commit

Permalink
chore(deps): update quay.io/thegeeklab/lhci docker tag to v0.13 (#760)
Browse files Browse the repository at this point in the history
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
  • Loading branch information
renovate[bot] and xoxys authored Jan 8, 2024
1 parent 7bdd16d commit 0e026ff
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 7 deletions.
2 changes: 2 additions & 0 deletions .lighthouserc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ ci:
image-size-responsive: off
render-blocking-resources: off
largest-contentful-paint: off
total-byte-weight: warn
identical-links-same-purpose: warn
tap-targets: warn
unsized-images: warn
# FIXME: /~https://github.com/GoogleChrome/lighthouse/issues/11460
Expand Down
2 changes: 1 addition & 1 deletion .woodpecker/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ steps:
- lychee --no-progress --format detailed exampleSite/content/ README.md

- name: page-validation
image: quay.io/thegeeklab/lhci:0.12
image: quay.io/thegeeklab/lhci:0.13
group: test
commands:
- lhci autorun
Expand Down
6 changes: 3 additions & 3 deletions exampleSite/content/en/usage/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ To prepare your new site environment just a few steps are required:

3. Install the Geekdoc theme from a [release bundle](#option-1-download-pre-build-release-bundle) (recommended) or from [Git branch](#option-2-clone-the-github-repository).

4. Create the minimal required Hugo configuration `config.toml`. For all configuration options take a look at the [configuration](/usage/configuration/) page.
4. Create the minimal required Hugo configuration `config.toml`. For all configuration options take a look at the [configuration page](/usage/configuration/).

```toml
baseURL = "http://localhost"
Expand Down Expand Up @@ -147,7 +147,7 @@ clean:
rm -rf $(BASEDIR)/public
```

This Makefile can be used in your `netlify.toml`, take a look at the Netlify [example](https://docs.netlify.com/configure-builds/file-based-configuration/#sample-netlify-toml-file) for more information:
This Makefile can be used in your `netlify.toml`, take a look at the [Netlify example](https://docs.netlify.com/configure-builds/file-based-configuration/#sample-netlify-toml-file) for more information:

```toml
[build]
Expand Down Expand Up @@ -193,7 +193,7 @@ Using `hugo --minify` without further configuration or using other minify tools

After some testing we decided to not spend effort to fix this issue for now as the benefit is very low. There are some parts of the theme where spaces between HTML elements matters but were stripped by minify tools. Some of these issues are related to <!-- spellchecker-disable -->[gohugoio/hugo#6892](/~https://github.com/gohugoio/hugo/issues/6892).<!-- spellchecker-enable --> While recommendation like "don't depend on whitespace in your layout" sounds reasonable, it seems to be not that straight forward especially for something like embedded icons into the text flow.

If you still want to use Hugo's minify flag you should at least exclude HTML file in your site [configuration](https://gohugo.io/getting-started/configuration/#configure-minify):
If you still want to use Hugo's minify flag you should at least exclude HTML files in your site configuration as described in the [Hugo documentation](https://gohugo.io/getting-started/configuration/#configure-minify):

```toml
[minify]
Expand Down
11 changes: 9 additions & 2 deletions src/sass/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,12 @@ svg.gdoc-icon {
background: var(--footer-background);
color: var(--footer-font-color);

.fake-link:hover {
background-image: linear-gradient(var(--footer-link-color), var(--footer-link-color));
.fake-link {
text-decoration: none;

&:hover {
background-image: linear-gradient(var(--footer-link-color), var(--footer-link-color));
}
}

&__item {
Expand All @@ -560,6 +564,7 @@ svg.gdoc-icon {
}

&__link {
text-decoration: underline;
color: var(--footer-link-color);

&:visited {
Expand Down Expand Up @@ -734,6 +739,7 @@ svg.gdoc-icon {

&__link,
&__link:visited {
text-decoration: underline;
color: var(--link-color);
}

Expand Down Expand Up @@ -773,6 +779,7 @@ svg.gdoc-icon {

a,
a:visited {
text-decoration: none !important;
color: var(--link-color);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/sass/_markdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

a,
&__link {
text-decoration: none;
text-decoration: underline;
border-bottom: $border-1 solid transparent;
line-height: normal;

Expand Down

0 comments on commit 0e026ff

Please sign in to comment.