Skip to content

Commit

Permalink
docs: correct some typos in CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
v.sioros committed Jul 21, 2021
1 parent be3bfc6 commit 8e8df0f
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Start by visiting the [Spotify Developer Portal](https://developer.spotify.com/d

The project utilizes the [pre-commit](https://pre-commit.com/) framework. Having [created a virtual environment and installed the required dependencies](#installing-poetry), you may run `pre-commit install` to install the [git hook scripts](/~https://github.com/the-dotify-project/dotify/blob/master/.pre-commit-config.yaml).

### Using `tox`
### Testing via `tox`

> We are using [tox](https://tox.readthedocs.io/en/latest/index.html) to automate testing on multiple environments.
Expand All @@ -88,12 +88,6 @@ You may also utilize [direnv](https://direnv.net/), so that you avoid re-exporti

_**ATTENTION**: Even though, using a `.envrc` file is far more convenient than re-exporting environment variables each and every time you open up a new shell, it is **strongly** recommended that, you prefer the first approach as you risk compromising your client credentials otherwise._

#### Using `poethepoet`

> We are using [poethepoet](/~https://github.com/nat-n/poethepoet), to perform various development oriented tasks.
Formatting, type-checking, running the test suite, as well as a few other operations, can be performed by running `poe <task>`. Please run `poe --help` (or `poetry run poe --help`), to list all available operations.

#### (Optional) Installing pyenv

[pyenv](/~https://github.com/pyenv/pyenv) is used, in the context of the **Dotify** project, in order to determine the project's compatibility with various versions of Python. Installing `pyenv` is not strictly required, but it is **strongly** recommended.
Expand All @@ -109,11 +103,17 @@ You will now be able to run `tox` (an as a result any test environment subset `p

Feel free to read more about using `pyenv`, in the context of `poetry`, [here](https://blog.jayway.com/2019/12/28/pyenv-poetry-saviours-in-the-python-chaos/).

### Performing development operations via `poethepoet`

> We are using [poethepoet](/~https://github.com/nat-n/poethepoet), to perform various development oriented tasks.
Formatting, type-checking, running the test suite, as well as a few other operations, can be performed by running `poe <task>`. Please run `poe --help` (or `poetry run poe --help`), to list all available operations.

### Documenting your changes

**Dotify** utilizes [MkDocs](https://www.mkdocs.org/) to build and deploy its documentation to [GitHub Pages](https://pages.github.com/). The documentation is auto-generated from the [python docstrings](https://www.python.org/dev/peps/pep-0257/#id15) throughout the source code. As a result, any code related change should be accompanied by a corresponding change to the method / class at hand.
**Dotify** utilizes [MkDocs](https://www.mkdocs.org/) to build and deploy its documentation to [GitHub Pages](https://pages.github.com/). The documentation is auto-generated from the [python docstrings](https://www.python.org/dev/peps/pep-0257/#id15) throughout the source code. As a result, any code related change should be accompanied by a corresponding change to the method's / class's docstring.

Having made your changes, please run `mkdocs server` and make sure that no error is being raised and the documentation renders fine.
Having made your changes, please run `poe docs` and make sure that no error is being raised on build time. Afterwards, open `http://localhost:8000/` in your browser of choice and make sure that the documentation renders correctly.

### Writing your commit message

Expand Down

0 comments on commit 8e8df0f

Please sign in to comment.