fix: convert Album.cover to a cached_property

the-dotify-project · Jun 8, 2021 · 6777ad3 · 6777ad3
1 parent 899006a
commit 6777ad3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/dotify/models/album.py b/dotify/models/album.py
@@ -4,6 +4,7 @@
 from typing import TYPE_CHECKING, AnyStr, Iterator, Optional
 
 import requests
+from cached_property import cached_property
 from mutagen.id3 import APIC
 from requests.models import HTTPError
 
@@ -44,7 +45,7 @@ def url(self) -> AnyStr:
         """
         return self.external_urls.spotify
 
-    @property
+    @cached_property
     def cover(self) -> APIC:
         """Return the cover art of the album.
 
@@ -57,7 +58,10 @@ def cover(self) -> APIC:
         response = requests.get(self.images[0].url)
 
         if response.status_code != HTTPStatus.OK.value:
-            raise HTTPError(response=response)
+            raise HTTPError(
+                "Failed to fetch %s" % (self.images[0].url,),
+                response=response,
+            )
 
         return APIC(
             encoding=3,

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -25,6 +25,7 @@ moviepy = "*"
 spotipy = "*"
 mutagen = "*"
 pytube = "*"
+cached-property = "^1.5.2"
 
 [tool.poetry.dev-dependencies]
 flake8 = "*"