-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add creation of icons for .desktop file #708
Conversation
Maybe @Vascom can help you out with this? |
As I found it is enough have only svg file. |
This PR has been catching dust, @joede could you verify svg is enough? |
@xor-gate I can try it within the next days. I expect that GNOME should work with this, but I can't say which other desktops needs images. So I only can test the icon usage with GNOME3! |
…esktop file to package name.
OK, the icon is visible in GNOME3. I've updated to PR to install the .desktop and the SVG icon with the Debian package. Therefore I have renamed the two files to Again: I don't know if the images are necessary for other desktops! Not all desktops use SVG... |
I suggest leaving only SVG and keeping track of bug reports. |
@Vascom agreed |
Thanks @joede for your contribution. |
The GUI doesn't provide the icons needed to work with the
.desktop
file. See #684! With this PR, I've added a script to create the necessaryhicolor
icons from the givenSVG
file.I'm no CMake user, so I don't know how to add the
.desktop
and the icons toCMakelist.txt
. After the installation is added to theCMakelist.txt
, thedebian/stlink-gui.install
must be patched too.This is still needed:
stlink.desktop
asstlink-gui.desktp
to/usr/share/applications/
(${CMAKE_INSTALL_DATADIR}/applications/
?)stlink-gui.xpm
to/usr/share/pixmaps/
hicolor/*
to/usr/share/icons/hicolor/
stlink-gui_icon.svg
to/usr/share/icons/hicolor/scalable/stlink-gui.svg