Warn when users are using fireEvent.input or .change directly #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 88 92 +4
Branches 28 30 +2
=========================================
+ Hits 88 92 +4
Continue to review full report at Codecov.
|
src/vue-testing-library.js
Outdated
|
|
||
| Object.keys(dtlFireEvent).forEach(key => { | ||
| fireEvent[key] = async (...args) => { | ||
| if (changeOrInputEventCalledDirectly(args[1], key)) { | ||
| console.warn( | ||
| 'By using "change" or "input", there may be unexpected issues. Please use "update" for a better experience.', |
There was a problem hiding this comment.
A small suggestion to (1) write down the used event key (so people have a better feedback on where to look for) and (2) to display "fireEvent.", so that people have the exact answer right there in the warning. Any other suggestion is welcome :)
| 'By using "change" or "input", there may be unexpected issues. Please use "update" for a better experience.', | |
| `Using "fireEvent.${key} may lead to unexpected results. Please use fireEvent.update() instead.`, |
There was a problem hiding this comment.
This makes sense, I'll make that change, thanks!
src/vue-testing-library.js
Outdated
|
|
||
| Object.keys(dtlFireEvent).forEach(key => { | ||
| fireEvent[key] = async (...args) => { | ||
| if (changeOrInputEventCalledDirectly(args[1], key)) { | ||
| console.warn( | ||
| `Using "fireEvent.{$key} may lead to unexpected results. Please use fireEvent.update() instead.`, |
There was a problem hiding this comment.
it should actually be
| `Using "fireEvent.{$key} may lead to unexpected results. Please use fireEvent.update() instead.`, | |
| `Using "fireEvent.${key} may lead to unexpected results. Please use fireEvent.update() instead.`, |
so that it renders "change" or "input" 😉
There was a problem hiding this comment.
Thanks for catching that!
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.