Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not create secret versions when using Cloud Build repositores second gen #324

Merged
merged 38 commits into from
Nov 1, 2024
Merged

fix: Do not create secret versions when using Cloud Build repositores second gen #324

merged 38 commits into from
Nov 1, 2024

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Oct 22, 2024 •
edited
Loading

This PR removed the creation of not secrets and secret versions in Terraform when using Cloud Build repositores second gen

additionally this PR also externalized the auto_create_network variable of the projects created by the modules

daniel-cit and others added 30 commits October 14, 2024 16:24
@daniel-cit
feat(deps): Update Terraform Google Provider to v6
ff93f1b
@daniel-cit
update project_services module to v17.0
911f5f7
@apeabody
Merge branch 'master' into major-terraform-google-provider-v6
9f95e76
@daniel-cit
update module simple_bucket version to v7.0
c84ebd6
@daniel-cit
increase integration build timeout to 90 minutes
e842581
@daniel-cit
refactor cloudbuild_repo_connection module
f6631a9
@daniel-cit
fix: do not create secrete versions in modules
0dfcda8
@daniel-cit
lint fixes
8d00648
@daniel-cit
tflint fixes
2e485c3
@daniel-cit
fix repository_uri variable
c2c9eac
@daniel-cit
integration test fixes
6412f19
@daniel-cit
fix github app id access
e7c36a6
@daniel-cit
replace for_each with count
3d34271
@daniel-cit
fix .git suffix
f80dcf5
@daniel-cit
Merge remote-tracking branch 'origin/major-terraform-google-provider-…
96b8afc 
…v6' into do-not-create-secrets
@daniel-cit
add wait for propagation of secret version creation
ccb2837
@daniel-cit
lint fixes
0c1f328
@daniel-cit
lint fixes
f4946df
@daniel-cit
Merge remote-tracking branch 'origin/master' into do-not-create-secrets
1b47228
@daniel-cit
update README instructions
e01a2d4
@daniel-cit
wait for secret version creation propagation
3da92c9
@daniel-cit
add time sleep for secret version creation
bfdad96
@daniel-cit
fix examples outputs
ca0e19a
@daniel-cit
log errors to output when internal build fails
27e96f1
@daniel-cit
print all logs
b4f99a1
@daniel-cit
add cloud build service agent fix for modules that create projects
685b59b
@daniel-cit
add module depends on in builder simpel example
cc75059
@daniel-cit
disable custom log output in test
e581b75
@daniel-cit
increase build timeout in test
c1ff50c
@daniel-cit
add custom cloud build sa to avoid name collision
8324c7b
@daniel-cit daniel-cit marked this pull request as ready for review October 31, 2024 19:00
@daniel-cit daniel-cit requested a review from a team as a code owner October 31, 2024 19:00
@daniel-cit
Copy link
Contributor Author

@bharathkkb @apeabody
Could you PTAL ?

apeabody
apeabody reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit! A few questions before we merge.

modules/cloudbuild/main.tf Outdated Show resolved Hide resolved
test/fixtures/cloudbuild_repo_connection_github/variables.tf Show resolved Hide resolved
test/fixtures/cloudbuild_repo_connection_gitlab/variables.tf Show resolved Hide resolved
test/fixtures/tf_cloudbuild_builder_simple_github/variables.tf Show resolved Hide resolved
test/fixtures/tf_cloudbuild_workspace_simple_github/variables.tf Show resolved Hide resolved
@apeabody apeabody self-assigned this Oct 31, 2024
apeabody
apeabody approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit!

@apeabody apeabody merged commit a6072e0 into terraform-google-modules:master Nov 1, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-cit @apeabody