Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed issue with multiple grants in aws_s3_bucket_acl #163

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

m4t22
Copy link
Contributor

@m4t22 m4t22 commented May 25, 2022

Description

It is ain't much but it's honest work it fixes issue with grant property failing the terraform plan.
Issue reported & described in details here: #162

Fixes #162

Motivation and Context

It is required to enable terraform plan to complete while using grant property.

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@m4t22 m4t22 mentioned this pull request May 25, 2022
1 task
@m4t22 m4t22 changed the title fix: issue with grant in aws_s3_bucket_acl resource fix: Issue with grant in aws_s3_bucket_acl resource May 25, 2022
@antonbabenko antonbabenko changed the title fix: Issue with grant in aws_s3_bucket_acl resource fix: Fixed issue with multiple grants in aws_s3_bucket_acl resource May 25, 2022
@antonbabenko antonbabenko changed the title fix: Fixed issue with multiple grants in aws_s3_bucket_acl resource fix: Fixed issue with multiple grants in aws_s3_bucket_acl May 25, 2022
@antonbabenko antonbabenko merged commit 9ed6eaa into terraform-aws-modules:master May 25, 2022
antonbabenko pushed a commit that referenced this pull request May 25, 2022
### [3.2.2](v3.2.1...v3.2.2) (2022-05-25)

### Bug Fixes

* Fixed issue with multiple grants in aws_s3_bucket_acl ([#163](#163)) ([9ed6eaa](9ed6eaa))
@antonbabenko
Copy link
Member

This PR is included in version 3.2.2 🎉

@antonbabenko
Copy link
Member

Thank you for this fix, @m4t22 !

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong definition of grant for s3
2 participants