Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated code to support Terraform 0.15 #136

Merged
merged 4 commits into from
Apr 19, 2021
Merged

feat: Updated code to support Terraform 0.15 #136

merged 4 commits into from
Apr 19, 2021

Conversation

afsmeira
Copy link
Contributor

Description

This PR updates the lambda module version and stops using Terraform functions that were deprecated.

Motivation and Context

This fixes issue #135 .

Breaking Changes

N/A

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

afsmeira and others added 3 commits April 19, 2021 11:58
Terraform 0.15 dropped support for the `list` function. In this case, an array literal can be used as an alternative.
Updating the lambda module to its latest version ensures that the Slack notifications module now supports Terraform 0.15.
@antonbabenko antonbabenko changed the title Support Terraform 0.15 feat: Updated code to support Terraform 0.15 Apr 19, 2021
@antonbabenko antonbabenko merged commit e05ef04 into terraform-aws-modules:master Apr 19, 2021
@antonbabenko
Copy link
Member

v4.14.0 has been just released.

@afsmeira
Copy link
Contributor Author

afsmeira commented Apr 19, 2021

@antonbabenko maybe we forgot to update the AWS provider version. The lambda module we're using now requires version 3.19 or above, and this module only requires version 2.35.

@antonbabenko
Copy link
Member

Terraform will pick the one which satisfies both statements, so it will be >= 3.19. We can update it in the next release.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants