feat: Add pass-through of ownership_verification_certificate_arn to domain_name #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name configuration
Done! |
antonbabenko
pushed a commit
that referenced
this pull request
Jun 13, 2022
## [1.9.0](v1.8.0...v1.9.0) (2022-06-13) ### Features * Add pass-through of ownership_verification_certificate_arn to domain_name ([#72](#72)) ([5709873](5709873))
|
This PR is included in version 1.9.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to also pass
ownership_verification_certificate_arntodomain_nameresource as new variable calleddomain_name_ownership_verification_certificate_arn. I followed existing patterns for defaults and naming conventions.Motivation and Context
Users may need to configure
ownership_verification_certificate_arnas part ofaws_apigatewayv2_domain_name. See provider docs for use casesBreaking Changes
N/A - defaults to null, which is currently implied
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request