Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default API Gateway integration method #14

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

abemedia
Copy link
Contributor

@abemedia abemedia commented Jan 8, 2021

Description

Integration method ANY is not supported. The reason you can't see it on the AWS Console is because it always defaults to POST.
The has nothing to do with the HTTP method used to call the API and is just how API Gateway calls the Lambda API (the handler will still receive the correct method).

Motivation and Context

Lambda proxy integrations were broken upon first deployment of our services, but worked as soon as they were edited and saved in the console (without making any changes). I investigated and realised that it's because an unsupported integration method was used and upon editing and saving the console automatically changed this to POST.

Breaking Changes

No

How Has This Been Tested?

Currently used in production in the company where I work.

@antonbabenko antonbabenko merged commit aad8168 into terraform-aws-modules:master Jan 14, 2021
@antonbabenko
Copy link
Member

Thanks for the clarification and for the fix!

v0.7.0 has been just released.

@abemedia
Copy link
Contributor Author

My pleasure!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants