feat: Add listener rules support for http/tcp listeners #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian0410
changed the title
|
Hello, |
|
@florian0410 Yes, I am going through all the terraform-aws-modules including this one now. Thank you for the PR! |
antonbabenko
changed the title
|
v6.4.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the
http_tcp_listener_rulesvariable defining rules for non https ports.It works the same as
https_listener_ruleson #155.Doc updated with the pre-commit hook.
Motivation and Context
We need to test rules creation on listeners before having SSL certificates implemented.
Since
https_listener_ruleswas the only way to do this, it was not yet possible to do the same for testing.Breaking Changes
No breaking change since it is a new feature.
How Has This Been Tested?
Tested using one of my company project, we created an ALB and some rules to forward traffic by using this new variable. Just used a temporary fork of this project with these changes.
Also updated the example to have some basic tests.
Ran pre-commit checks to ensure formatting and terraform validate pass.
Closes #214
Ref #176