Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support weight in forward action #211

Closed
siutsin opened this issue Jul 1, 2021 · 5 comments · Fixed by #224
Closed

Feature request: Support weight in forward action #211

siutsin opened this issue Jul 1, 2021 · 5 comments · Fixed by #224

Comments

@siutsin
Copy link

siutsin commented Jul 1, 2021

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

I am looking for a weighted forward action described at lb_listener_rule. However, it seems it is not currently supported in this module.

Describe the solution you'd like.

Support the syntax described in lb_listener_rule. E.g.

resource "aws_lb_listener_rule" "host_based_routing" {
  listener_arn = aws_lb_listener.front_end.arn
  priority     = 99

  action {
    type = "forward"
    forward {
      target_group {
        arn    = aws_lb_target_group.main.arn
        weight = 80
      }

      target_group {
        arn    = aws_lb_target_group.canary.arn
        weight = 20
      }

      stickiness {
        enabled  = true
        duration = 600
      }
    }
  }

  condition {
    host_header {
      values = ["my-service.*.terraform.io"]
    }
  }
}

Describe alternatives you've considered.

Additional context

@alexbricepalo
Copy link
Contributor

+1 for this feature

@antonbabenko
Copy link
Member

Pull request is welcome.

@alexbricepalo
Copy link
Contributor

Pull request is welcome.

Yup, I was just looking into doing that.

@alexbricepalo
Copy link
Contributor

alexbricepalo commented Oct 16, 2021

Pull request: #224

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants