Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused (depracated) input variable #136

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Removed unused (depracated) input variable #136

merged 1 commit into from
Mar 5, 2020

Conversation

tomasbackman
Copy link
Contributor

PR o'clock

Description

Removed an old leftover input variable no longer used.
For backwards compatibility it could instead be used for "prefix" in access_logs variable, but personally I think that would just make it more confusing.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/alb_test_fixture directories (look in CI for an example)
  • [-] Tests for the changes have been added and passing (for bug fixes/features)
  • [-] Test results are pasted in this PR (in lieu of CI)
  • [- Not mentioned in docs] Docs have been added/updated (for bug fixes/features)
  • [v] Any breaking changes are noted in the description above

Use existing input variable access_logs for log prefix
@antonbabenko antonbabenko merged commit c505772 into terraform-aws-modules:master Mar 5, 2020
@antonbabenko
Copy link
Member

Thank you for this pull-request, @tomasbackman !

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants