Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error messages in tensor()/tensorXd() #424

Closed
dsmilkov opened this issue Jun 13, 2018 · 1 comment
Closed

Improve the error messages in tensor()/tensorXd() #424

dsmilkov opened this issue Jun 13, 2018 · 1 comment
Assignees
@dsmilkov
Labels
comp:core

Comments

@dsmilkov
Copy link
Contributor

dsmilkov commented Jun 13, 2018 •
edited
Loading

For example:

  • if someone calls tf.tensor() with a null shape, we say Error: Constructing tensor of shape (NaN) should match the length of values (0). Instead we should just say the shape is null.
  • if someone calls tf.tensor() with values as null, we should say values is null, instead of saying that values is not a Flat/TypedArray.

See this discussion for context.
@dsmilkov dsmilkov self-assigned this Jun 13, 2018
@dsmilkov dsmilkov changed the title Improve the error messages in tensorxd() Improve the error messages in tensor()/tensorXd() Jun 13, 2018
@Lewuathe Lewuathe mentioned this issue Jun 17, 2018
Merged
@Lewuathe Lewuathe mentioned this issue Jun 25, 2018
Closed
@dsmilkov
Copy link
Contributor Author

dsmilkov commented Jul 1, 2018

Fixed in tensorflow/tfjs-core#1111

@dsmilkov dsmilkov closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmilkov dsmilkov

Labels
comp:core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsmilkov