Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand why epsilon checks are necessary in packed division and add test exposing root issue. #1324

Closed
annxingyuan opened this issue Mar 5, 2019 · 0 comments · Fixed by tensorflow/tfjs-core#1660
Assignees

Comments

@annxingyuan
Copy link
Contributor

annxingyuan commented Mar 5, 2019

This issue (#1321) prompted this fix (tensorflow/tfjs-core#1603) of checking whether the inputs to packed div are less than epsilon and setting the output to 0 if so. We need to understand why it's necessary to check for less than epsilon, rather than equals 0.

We also need to understand why the inputs were 0's. I thought it was because they were in out-of-bounds channels, but an alternative fix of checking whether rc channels were out of bounds did not fix the problem. So that makes it seem like the inputs were 0's in the data, but the unpacked version of division did not produce NaNs.

@annxingyuan annxingyuan self-assigned this Mar 5, 2019
@annxingyuan annxingyuan changed the title Understand why epsilon checks are necessary in packed division. Understand why epsilon checks are necessary in packed division and add test exposing root issue. Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant