Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs/log: [JSON format] include timestamp #6174

Merged
merged 8 commits into from
Feb 25, 2021
Merged

libs/log: [JSON format] include timestamp #6174

merged 8 commits into from
Feb 25, 2021

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Feb 24, 2021

Closes #6146

@melekes melekes added S:automerge Automatically merge PR when requirements pass S:backport-to-v0.34.x Tell mergify to backport the PR to v0.34.x labels Feb 24, 2021
@melekes melekes self-assigned this Feb 24, 2021
@melekes melekes marked this pull request as ready for review February 24, 2021 07:22
@melekes melekes marked this pull request as draft February 24, 2021 18:46
@melekes melekes marked this pull request as ready for review February 24, 2021 18:52
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #6174 (7a2fa67) into master (4557211) will increase coverage by 0.17%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #6174      +/-   ##
==========================================
+ Coverage   60.67%   60.84%   +0.17%     
==========================================
  Files         276      276              
  Lines       25716    25716              
==========================================
+ Hits        15602    15646      +44     
+ Misses       8486     8452      -34     
+ Partials     1628     1618      -10
Impacted Files Coverage Δ
cmd/tendermint/commands/light.go 16.55% <0.00%> (ø)
rpc/jsonrpc/client/http_json_client.go 10.85% <0.00%> (ø)
statesync/stateprovider.go 0.00% <0.00%> (ø)
libs/log/tm_json_logger.go 40.00% <40.00%> (-60.00%) ⬇️
rpc/jsonrpc/client/ws_client.go 63.08% <92.30%> (+4.82%) ⬆️
light/provider/http/http.go 52.12% <100.00%> (ø)
crypto/sr25519/pubkey.go 43.47% <0.00%> (-8.70%) ⬇️
consensus/reactor.go 68.80% <0.00%> (-1.10%) ⬇️
p2p/pex/pex_reactor.go 76.48% <0.00%> (-0.60%) ⬇️
consensus/state.go 66.41% <0.00%> (-0.10%) ⬇️
... and 14 more

@mergify mergify bot merged commit fc5a108 into master Feb 25, 2021
@mergify mergify bot deleted the anton/6146-json-ts branch February 25, 2021 07:06
mergify bot pushed a commit that referenced this pull request Feb 25, 2021
@melekes
libs/log: [JSON format] include timestamp (#6174)
ddd126d 
Closes #6146

(cherry picked from commit fc5a108)

# Conflicts:
#	CHANGELOG_PENDING.md
@mergify mergify bot mentioned this pull request Feb 25, 2021
Merged
melekes pushed a commit that referenced this pull request Feb 25, 2021
@mergify
libs/log: [JSON format] include timestamp (bp #6174) (#6179)
28ce355 
Closes #6146
@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
This was referenced Apr 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

Assignees

@melekes melekes

Labels
S:automerge Automatically merge PR when requirements pass S:backport-to-v0.34.x Tell mergify to backport the PR to v0.34.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamp not included in log output in JSON log format
3 participants
@melekes @alexanderbez @tac0turtle