state sync: last consensus params height is not set

[cmwaters]

Description

When state syncing, we currently don't save state.LastHeightConsensusParamsChanged. This causes it to be set with a value of 0 when it is saved to the state store. Bootstap() the function that is called ignores this value

if err := store.saveConsensusParamsInfo(height, height, state.ConsensusParams); err != nil {
	return err
}

However, state keeps the 0 value meaning at following heights when state is saved, LastHeightConsensusParamsChanged is 0

if err := store.saveConsensusParamsInfo(nextHeight,
        state.LastHeightConsensusParamsChanged, state.ConsensusParams); err != nil {
	return err
}

This means that the state store isn't saving the consensus params rather referencing the consensus params at height 0 which don't exist and causes this error to arise when pruning:

err="failed to prune state store: couldn't find consensus params at height 0 as last changed from height 11: value retrieved from db is empty"

The second part of this is that we are requesting the consensus params of state.LastBlockHeight + 2 and saving it as state.LastBlockHeight + 1

[codecov]

Codecov Report

Merging #5889 (09c4e45) into master (956b59a) will decrease coverage by 0.11%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master    #5889      +/-   ##
==========================================
- Coverage   59.91%   59.79%   -0.12%     
==========================================
  Files         269      269              
  Lines       24550    24552       +2     
==========================================
- Hits        14708    14681      -27     
- Misses       8240     8266      +26     
- Partials     1602     1605       +3     

Impacted Files	Coverage Δ
statesync/stateprovider.go	0.00% <0.00%> (ø)
state/store.go	55.89% <50.00%> (+0.16%)	⬆️
crypto/sr25519/pubkey.go	43.47% <0.00%> (-8.70%)	⬇️
consensus/reactor.go	73.83% <0.00%> (-3.65%)	⬇️
libs/autofile/autofile.go	69.35% <0.00%> (-3.23%)	⬇️
statesync/snapshots.go	91.59% <0.00%> (-1.69%)	⬇️
mempool/reactor.go	80.83% <0.00%> (-1.67%)	⬇️
mempool/clist_mempool.go	80.57% <0.00%> (-0.72%)	⬇️
p2p/router.go	70.00% <0.00%> (ø)
proxy/multi_app_conn.go	48.05% <0.00%> (ø)
... and 5 more

[tac0turtle]

utACK 👍

[melekes]

👍

[melekes]

changelog entry is missing

[alexanderbez]

nit: the following reads easier IMHO

if err := store.saveConsensusParamsInfo(
  height, state.LastHeightConsensusParamsChanged, state.ConsensusParams,
); err != nil {
  // ...
}