Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: tx search pagination duplicates #4432

Closed
erikgrinaker opened this issue Feb 19, 2020 · 0 comments · Fixed by #4437
Closed

rpc: tx search pagination duplicates #4432

erikgrinaker opened this issue Feb 19, 2020 · 0 comments · Fixed by #4437
Assignees
@erikgrinaker
Labels
C:rpc Component: JSON RPC, gRPC T:bug Type Bug (Confirmed)

Comments

@erikgrinaker
Copy link
Contributor

@alexanderbez says:

txs search pagination seems to have regressed
do 2 queries:
page=1&per_page=5
page=2&per_page=5
you'll get dup txs in both results
@erikgrinaker erikgrinaker added T:bug Type Bug (Confirmed) C:rpc Component: JSON RPC, gRPC labels Feb 19, 2020
@erikgrinaker erikgrinaker self-assigned this Feb 19, 2020
@erikgrinaker erikgrinaker mentioned this issue Feb 19, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
C:rpc Component: JSON RPC, gRPC T:bug Type Bug (Confirmed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: fix tx_search pagination with ordered results tendermint/tendermint
1 participant
@erikgrinaker