fix style, tests for policy type "all"

pkg/policy/all_test.go

@@ -0,0 +1,51 @@
+/*
+    Copyright (C) 2020 Accurics, Inc.
+
+	Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+		http://www.apache.org/licenses/LICENSE-2.0
+
+	Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+*/
+
+package policy
+
+import (
+	"reflect"
+	"sort"
+	"testing"
+)
+
+func TestPolicyTypeAllExpandedCorrectly(t *testing.T) {
+	t.Run("policy type all gets right policy names", func(t *testing.T) {
+
+		want := SupportedPolicyTypes(false)
+		got := supportedCloudProvider["all"].policyNames()
+
+		sort.Strings(want)
+		sort.Strings(got)
+
+		if !reflect.DeepEqual(got, want) {
+			t.Errorf("got: '%v', want: '%v'", got, want)
+		}
+	})
+
+	t.Run("policy type all gets right policy paths", func(t *testing.T) {
+
+		want := GetDefaultPolicyPaths(SupportedPolicyTypes(false))
+		got := GetDefaultPolicyPaths([]string{"all"})
+
+		sort.Strings(want)
+		sort.Strings(got)
+
+		if !reflect.DeepEqual(got, want) {
+			t.Errorf("got: '%v', want: '%v'", got, want)
+		}
+	})
+}

pkg/policy/cloud-providers.go

@@ -75,7 +75,6 @@ func RegisterIndirectCloudProvider(cloudType supportedCloudType, iacTypeDefault
 	registerActualCloudProvider(cloudType, iacTypeDefault, iacVersionDefault, true, getPolicyNames)
 }
 
-// IsCloudProviderSupported returns whether a cloud provider is supported in terrascan
 // RegisterCloudProvider registers a cloud provider with terrascan
 func RegisterCloudProvider(cloudType supportedCloudType, iacTypeDefault supportedIacType, iacVersionDefault supportedIacVersion) {
 	registerActualCloudProvider(cloudType, iacTypeDefault, iacVersionDefault, false, func() []string { return []string{basePolicyPath + "/" + string(cloudType)} })

pkg/policy/cloud-providers_test.go

@@ -36,7 +36,7 @@ func TestSupportedPolicyTypes(t *testing.T) {
 	})
 }
 
-func TestSupportediNotIndirectPolicyTypes(t *testing.T) {
+func TestSupportedNotIndirectPolicyTypes(t *testing.T) {
 	t.Run("supported policy types", func(t *testing.T) {
 		var want []string
 		for k, v := range supportedCloudProvider {

pkg/policy/types.go

@@ -18,13 +18,15 @@ type EngineOutput struct {
 	*results.ViolationStore `json:"results" yaml:"results" xml:"results"`
 }
 
+// EngineOutputFromViolationStore returns an EngineOutput intialized from ViolationStore
 func EngineOutputFromViolationStore(store *results.ViolationStore) EngineOutput {
 	return EngineOutput{
 		xml.Name{},
 		store,
 	}
 }
 
+// AsViolationStore returns EngineOutput as a ViolationStore
 func (me EngineOutput) AsViolationStore() results.ViolationStore {
 	if me.ViolationStore == nil {
 		return results.ViolationStore{}