Remove docker flag that disables versioning tests (#1771)

temporalio · Jan 10, 2025 · a708f7e · a708f7e
1 parent b8f9b44
commit a708f7e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 29 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,7 +23,6 @@ jobs:
             runsOn: macos-13
           - os: macos-arm
             runsOn: macos-14
-
     runs-on: ${{ matrix.runsOn || matrix.os }}
     steps:
       - name: Checkout repository
@@ -88,9 +87,6 @@ jobs:
       - name: Docker compose - integration tests
         if: ${{ matrix.testDockerCompose }}
         run: go run . integration-test
-        env:
-          # TODO(antlai-temporal): Remove this flag once server 1.26.2 released.
-          DISABLE_DEPLOYMENT_TESTS: "1"
         working-directory: ./internal/cmd/build
 
   cloud-test:

diff --git a/.github/workflows/docker/dynamic-config-custom.yaml b/.github/workflows/docker/dynamic-config-custom.yaml
@@ -17,6 +17,8 @@ frontend.workerVersioningDataAPIs:
   - value: true
 frontend.workerVersioningWorkflowAPIs:
   - value: true
+system.enableDeployments:
+  - value: true
 worker.buildIdScavengerEnabled:
   - value: true
 worker.removableBuildIdDurationSinceDefault:

diff --git a/test/deployment_test.go b/test/deployment_test.go
@@ -24,7 +24,6 @@ package test_test
 
 import (
 	"context"
-	"os"
 	"reflect"
 	"sort"
 	"strings"
@@ -100,9 +99,6 @@ func (ts *DeploymentTestSuite) waitForReachability(ctx context.Context, deployme
 }
 
 func (ts *DeploymentTestSuite) TestPinnedBehaviorThreeWorkers() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
 	defer cancel()
 
@@ -250,9 +246,6 @@ func (ts *DeploymentTestSuite) TestPinnedBehaviorThreeWorkers() {
 }
 
 func (ts *DeploymentTestSuite) TestPinnedOverrideInWorkflowOptions() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
 	defer cancel()
 
@@ -333,9 +326,6 @@ func (ts *DeploymentTestSuite) TestPinnedOverrideInWorkflowOptions() {
 }
 
 func (ts *DeploymentTestSuite) TestUpdateWorkflowExecutionOptions() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
 	defer cancel()
 
@@ -498,9 +488,6 @@ func (ts *DeploymentTestSuite) TestUpdateWorkflowExecutionOptions() {
 }
 
 func (ts *DeploymentTestSuite) TestListDeployments() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
 	defer cancel()
 
@@ -567,9 +554,6 @@ func (ts *DeploymentTestSuite) TestListDeployments() {
 }
 
 func (ts *DeploymentTestSuite) TestDeploymentReachability() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	ctx, cancel := context.WithTimeout(context.Background(), 100*time.Second)
 	defer cancel()
 

diff --git a/test/integration_test.go b/test/integration_test.go
@@ -6262,9 +6262,6 @@ func (ts *IntegrationTestSuite) TestScheduleUpdateWorkflowActionMemo() {
 }
 
 func (ts *IntegrationTestSuite) TestVersioningBehaviorInRespondWorkflowTaskCompletedRequest() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	versioningBehaviorAll := make([]enumspb.VersioningBehavior, 0)
 	ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
 	defer cancel()
@@ -6333,9 +6330,6 @@ func (ts *IntegrationTestSuite) TestVersioningBehaviorInRespondWorkflowTaskCompl
 }
 
 func (ts *IntegrationTestSuite) TestVersioningBehaviorPerWorkflowType() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	versioningBehaviorAll := make([]enumspb.VersioningBehavior, 0)
 	ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
 	defer cancel()
@@ -6409,9 +6403,6 @@ func (ts *IntegrationTestSuite) TestVersioningBehaviorPerWorkflowType() {
 }
 
 func (ts *IntegrationTestSuite) TestNoVersioningBehaviorPanics() {
-	if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
-		ts.T().Skip("temporal server 1.26.2+ required")
-	}
 	seriesName := "deploy-test-" + uuid.New()
 
 	c, err := client.Dial(client.Options{