Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST]: Statsd support for metrics #265

Closed
cv65kr opened this issue Aug 29, 2022 · 3 comments · Fixed by #267
Closed

[💡 FEATURE REQUEST]: Statsd support for metrics #265

cv65kr opened this issue Aug 29, 2022 · 3 comments · Fixed by #267
Assignees
Labels
C-feature-accepted Category: Feature discussed and accepted P-Medium Priority: Medium
Milestone

Comments

@cv65kr
Copy link
Contributor

cv65kr commented Aug 29, 2022

Plugin

Temporal

I have an idea!

Since Temporal can supports statsd and prometheus via Tally. Would be nice to have the same feature for metrics client in Roadrunner.

@cv65kr cv65kr added the C-feature-request Category: feature requested, but need to be discussed label Aug 29, 2022
@rustatian
Copy link
Collaborator

Hey @cv65kr 👋
RR already supports all temporal metrics: /~https://github.com/roadrunner-server/roadrunner/blob/master/.rr.yaml#L193

@cv65kr
Copy link
Contributor Author

cv65kr commented Aug 30, 2022

Hi @rustatian
But as far I see in code, there are can be emitting only for prometheus.
Temporal itself supports multiple clients - https://docs.temporal.io/references/configuration/#statsd

@rustatian
Copy link
Collaborator

Hi @rustatian But as far I see in code, there are can be emitting only for prometheus. Temporal itself supports multiple clients - https://docs.temporal.io/references/configuration/#statsd

Yeah, you're right. I thought that you didn't know about Prometheus in the RR. So yeah, we'll need to have identical providers here.

@rustatian rustatian added C-feature-accepted Category: Feature discussed and accepted P-Medium Priority: Medium and removed C-feature-request Category: feature requested, but need to be discussed labels Aug 30, 2022
@rustatian rustatian added this to the v1.5.x milestone Aug 30, 2022
@rustatian rustatian modified the milestones: v1.5.x, v1.6.x Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-accepted Category: Feature discussed and accepted P-Medium Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants