Fix crash on screen rotation #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 25, 2022 10:41
Claire1817
reviewed
Jan 25, 2022
vector/src/main/java/im/vector/app/features/home/room/list/RoomListFragment.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/room/list/RoomListFragment.kt
Outdated
Show resolved
Hide resolved
|
The search bar doesn't take all the available space when you have a research in landscape mode. |
Claire1817
suggested changes
Jan 26, 2022
vector/src/main/java/im/vector/app/features/home/HomeDetailFragment.kt
Outdated
Show resolved
Hide resolved
Claire1817
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#370
This crash was triggered by the
SearchView. This PR reworks the search feature which is now directly handled by the RoomListFragment