-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slack)!: add socket mode support #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1042741970
💛 - Coveralls |
just working on some documentation changes for this .. hang tight :D |
docs are added/modified: target/flottbot-docs#49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤ THANKS FOR HELPING OUT :D
Proposed change
The main change is the support for Slack's Socket Mode which replaces the legacy RTM implementation. Enhancements and upgrades enumerated below:
slack_app_token
in addition toslack_token
slack_workspace_token
(instead, make sure you have theusergroups:read
scope)BREAKING CHANGE:
slack_verification_token
is deprecated by Slack and removed with this PR. It is replaced byslack_signing_secret
.closes #130
Types of changes
What types of changes is this pull request introducing to flottbot? Put an
x
in the boxes that applyChecklist
You can fill this out after creating your PR. Put an
x
in the boxes that apply