Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(templates): switch from gtf to sprig #118

Merged
merged 1 commit into from
Dec 4, 2019
Merged

refactor(templates): switch from gtf to sprig #118

merged 1 commit into from
Dec 4, 2019

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 21, 2019 •
edited
Loading

❤ THANKS FOR HELPING OUT :D

Proposed change

Using sprig instead of gtf for added functions. Also updates dependencies.

closes #71

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 248

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.121%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/matcher.go 3 4 75.0%
Totals Coverage Status
Change from base Build 246: 0.0%
Covered Lines: 796
Relevant Lines: 1984
💛 - Coveralls

pa3ng
pa3ng approved these changes Dec 4, 2019
View reviewed changes
Copy link

@pa3ng pa3ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pa3ng pa3ng merged commit 9087a96 into master Dec 4, 2019
@pa3ng pa3ng deleted the use-sprig branch December 4, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pa3ng pa3ng pa3ng approved these changes

@JordanSussman JordanSussman Awaiting requested review from JordanSussman

@sjqnn sjqnn Awaiting requested review from sjqnn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use sprigs instead of gtf for golang templates
3 participants
@wass3r @coveralls @pa3ng