-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated docker files to use go modules #105
Conversation
If we're ripping out dep from all of the image flavored Dockerfiles, we may as well remove it from the base |
@sjqnn Updated that one too:) |
LGTM besides the one minor Makefile update. |
I just resolved the merge conflicts and addressed the one issue for the Makefile. Anyone else have objections to getting this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
❤ THANKS FOR HELPING OUT :D
Proposed change
Updates docker files.
closes #103
Types of changes
What types of changes is this pull request introducing to flottbot? Put an
x
in the boxes that applyChecklist
You can fill this out after creating your PR. Put an
x
in the boxes that apply