Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalan translations #229

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Conversation

victormhg
Copy link
Contributor

Added catalan translations to bundle

@@ -0,0 +1,51 @@
<?xml version="1.0" encoding="UTF-8" ?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
<file original="file.ext" source-language="en" datatype="plaintext">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing target-language attr, see any diffrent from en translation:

Suggested change
<file original="file.ext" source-language="en" datatype="plaintext">
<file original="file.ext" source-language="en" target-language="ca" datatype="plaintext">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the target language attribute, nevertheless a lot of other language files hasn't this attribute.

Copy link
Contributor Author

@victormhg victormhg Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not "a lot" but "some" ;-)

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding more translations!

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer Feature New Feature labels Jul 5, 2022
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @victormhg

@jrushlow jrushlow merged commit 8dceda7 into SymfonyCasts:main Jul 5, 2022
@jrushlow jrushlow mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants