Reduce common control flows

symfony · Oct 14, 2024 · 887061a · 887061a
1 parent 0a0eb06
commit 887061a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/Dumper/PhpDumper.php b/Dumper/PhpDumper.php
@@ -1139,16 +1139,15 @@ private function addNewInstance(Definition $definition, string $return = '', ?st
     {
         $tail = $return ? str_repeat(')', substr_count($return, '(') - substr_count($return, ')')).";\n" : '';
 
+        $arguments = [];
         if (BaseServiceLocator::class === $definition->getClass() && $definition->hasTag($this->serviceLocatorTag)) {
-            $arguments = [];
             foreach ($definition->getArgument(0) as $k => $argument) {
                 $arguments[$k] = $argument->getValues()[0];
             }
 
             return $return.$this->dumpValue(new ServiceLocatorArgument($arguments)).$tail;
         }
 
-        $arguments = [];
         foreach ($definition->getArguments() as $i => $value) {
             $arguments[] = (\is_string($i) ? $i.': ' : '').$this->dumpValue($value);
         }