Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings/node): Add VisitTsPropertySignature #9670

Merged

Conversation

jzhan-canva
Copy link
Contributor

Description:

As per PR #8955

TsPropertySignature can not have params, type params, or an initializer.

This PR clean up these fields from ts definition and visitor

@jzhan-canva jzhan-canva requested a review from a team as a code owner October 23, 2024 03:42
Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: c294d79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #9670 will degrade performances by 4.12%

Comparing jzhan-canva:jzhan-fix-visitTsPropertySignature (c294d79) with main (8f45eaf)

Summary

❌ 2 regressions
✅ 192 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jzhan-canva:jzhan-fix-visitTsPropertySignature Change
es/full/bugs-1 518.8 µs 541.1 µs -4.12%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.63%

@kdy1 kdy1 added this to the Planned milestone Oct 24, 2024
@kdy1 kdy1 changed the title fix visitTsPropertySignature fix(bindings/node): Add VisitTsPropertySignature Oct 24, 2024
@kdy1 kdy1 merged commit 715c42c into swc-project:main Oct 24, 2024
152 of 153 checks passed
@kdy1 kdy1 modified the milestones: Planned, 1.7.38 Oct 26, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants