Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Fix source map so it works with Sentry #9627

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Oct 8, 2024

Description:

Fix web-infra-dev/rspack#7914

The following mapping is redundant and causes an error on Sentry.

image

Your source map refers to generated column 79 on line 1, but the source only contains 78 column(s) on that line.

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: cd97f33

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SyMind SyMind marked this pull request as ready for review October 9, 2024 01:46
@SyMind SyMind requested a review from a team as a code owner October 9, 2024 01:46
@CPunisher CPunisher self-assigned this Oct 9, 2024
CPunisher
CPunisher previously approved these changes Oct 9, 2024
@CPunisher CPunisher assigned kdy1 and unassigned CPunisher Oct 9, 2024
@SyMind
Copy link
Contributor Author

SyMind commented Oct 9, 2024

@CPunisher @kdy1 I am wondering if all tests have passed and if the PR is acceptable. When can SWC release a new version?

@kdy1 kdy1 added this to the Planned milestone Oct 10, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 10, 2024 01:23
@kdy1 kdy1 changed the title fix: source map is not working on Sentry fix(es/codegen): Fix source map so it works with Sentry Oct 10, 2024
@kdy1
Copy link
Member

kdy1 commented Oct 10, 2024

It's acceptable, and I'll publish Rust crates asap. Do you mean you need a new version of @swc/core?

@kdy1 kdy1 merged commit 9c90a73 into swc-project:main Oct 10, 2024
22 of 24 checks passed
@kdy1
Copy link
Member

kdy1 commented Oct 10, 2024

For Rust crates, here you go. /~https://github.com/swc-project/swc/releases/tag/swc_core%40v0.109.1

@SyMind SyMind deleted the fix-source-map branch October 10, 2024 02:42
@kdy1 kdy1 modified the milestones: Planned, v1.7.33 Oct 10, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The source map is not working on Sentry
3 participants