fix(es/minifier): Prevent removing side effects from accessing getter

[CPunisher]

Closes #9500

Caused by

swc/crates/swc_ecma_minifier/src/compress/pure/misc.rs

Line 1547 in c7fdd6b

self.ignore_return_value(obj, opts);

. When the object with getters pass to self.ignore_return_value,

swc/crates/swc_ecma_minifier/src/compress/pure/misc.rs

Line 966 in c7fdd6b

self.optimize_expr_in_bool_ctx(e, true);

converts the object to 0 because the object is side-effect-free according to

swc/crates/swc_ecma_utils/src/lib.rs

Line 1496 in c7fdd6b

Expr::Object(ObjectLit { props, .. }) => props.iter().any(|node| match node {

We should skip this process to fix the issue.

As is known only accessing getters and setters may cause side effect, we can safely do the transformation when none of them appears in the object. More precision is possible if comparing the lit prop names. I also collect computed keys of getters and setters in the object, is there any bad case?

The reason why only numeric (string) key removes the statement is that string key (Computed) is converted to Ident in other phases, e.g. {}['a'] => {}.a, which does not matching the pattern.

[changeset-bot]

🦋 Changeset detected

Latest commit: 78cb61a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #9530 will degrade performances by 3.52%

_{Comparing CPunisher:fix/member-expression (78cb61a) with main (84b0043)}

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	CPunisher:fix/member-expression	Change
❌	es/full/bugs-1	529.3 µs	548.7 µs	-3.52%

[Austaras]

Better to add tests at issues/9500, otherwise good.