Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Iterate object properties in reverse direction while inlining property access #9507

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 28, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 28, 2024
@kdy1 kdy1 self-assigned this Aug 28, 2024
@kdy1 kdy1 requested a review from a team as a code owner August 28, 2024 00:45
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 28, 2024
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 0a58cb3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 requested a review from a team as a code owner August 28, 2024 00:45
Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #9507 will not alter performance

Comparing kdy1:issue-9498 (0a58cb3) with main (da52930)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 merged commit f584ef7 into swc-project:main Aug 29, 2024
155 checks passed
@kdy1 kdy1 deleted the issue-9498 branch August 29, 2024 06:58
@kdy1 kdy1 modified the milestones: Planned, v1.7.23 Sep 2, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minifier incorrectly inlines object property with duplicated key from spreaded object
1 participant