Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Simplify SyntaxContext and Mark #9346

Closed
kdy1 opened this issue Jul 30, 2024 · 3 comments · Fixed by #9476
Closed

RFC: Simplify SyntaxContext and Mark #9346

kdy1 opened this issue Jul 30, 2024 · 3 comments · Fixed by #9476
Assignees
Milestone

Comments

@kdy1
Copy link
Member

kdy1 commented Jul 30, 2024

We don't use complex features of SyntaxContext nor Mark.

For @swc/core and next-swc, we only need

  • Parent-child relationship for Mark
  • SyntaxContext.apply_mark()

But I want to know if there's a project using more complex features.

@kdy1 kdy1 added this to the Planned milestone Jul 30, 2024
@kdy1 kdy1 self-assigned this Jul 30, 2024
@g-plane
Copy link
Contributor

g-plane commented Jul 30, 2024

What're complex features?

@kdy1
Copy link
Member Author

kdy1 commented Jul 30, 2024

@swc-bot
Copy link
Collaborator

swc-bot commented Sep 23, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants