(fix) Clear outDir if set in tsconfig #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If outDir is set, Typescript sets directories in the source maps relative to it which causes problems in `concatSourceMaps` when the paths in the source point to nonexistent files instead of the virtual modules set up by the transformer. Fixes sveltejs#405
dummdidumm
approved these changes
Sep 13, 2021
|
Thanks 🎉 Released in v4.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #405. Since it's a quick fix I decided to just submit the PR before any discussion. Happy to discuss more if you're not sure if this is the right thing to do.
If outDir is set, Typescript sets directories in the source maps relative to it
which causes problems in
concatSourceMapswhen the paths in the sourcepoint to nonexistent files instead of the virtual modules set up by the
transformer.
Tested against /~https://github.com/dimfeld/svelte-preprocess-injected-bug and also added a new unit test.
Fixes #405