Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adapter-node] unmet peer dependencies #12814

Closed
hyunbinseo opened this issue Oct 15, 2024 · 1 comment · Fixed by #12817
Closed

[adapter-node] unmet peer dependencies #12814

hyunbinseo opened this issue Oct 15, 2024 · 1 comment · Fixed by #12817

Comments

@hyunbinseo
Copy link
Contributor

hyunbinseo commented Oct 15, 2024

Describe the bug

Installing @sveltejs/adapter-node in pnpm shows the following warning:

Reproduction

pnpm i @sveltejs/adapter-node

# Packages: +71
# +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
# Progress: resolved 108, reused 71, downloaded 0, added 71, done
# node_modules/.pnpm/@sveltejs+kit@2.7.1_@sveltejs+vite-plugin-svelte@3.1.2_svelte@4.2.19_vite@5.4.9__svelte@4.2.19_vite@5.4.9/node_modules/@sveltejs/kit: Runningnode_modules/.pnpm/@sveltejs+kit@2.7.1_@sveltejs+vite-plugin-svelte@3.1.2_svelte@4.2.19_vite@5.4.9__svelte@4.2.19_vite@5.4.9/node_modules/@sveltejs/kit: Running postinstall script, done in 158ms

# dependencies:
# + @sveltejs/adapter-node 5.2.7

#  WARN  Issues with peer dependencies found
# .
# └─┬ @sveltejs/adapter-node 5.2.7
#   └─┬ @rollup/plugin-commonjs 28.0.0
#     └─┬ fdir 6.4.0
#       └── ✕ unmet peer picomatch@"^3 || ^4": found 2.3.1

Logs

No response

System Info

System:
  OS: macOS 15.0.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 65.06 MB / 16.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 22.9.0 - ~/.local/state/fnm_multishells/86757_1729006755260/bin/node
  npm: 10.8.3 - ~/.local/state/fnm_multishells/86757_1729006755260/bin/npm
  pnpm: 9.12.1 - ~/.local/state/fnm_multishells/86757_1729006755260/bin/pnpm
Browsers:
  Chrome: 129.0.6668.100
  Edge: 129.0.2792.89
  Safari: 18.0.1
npmPackages:
  @sveltejs/adapter-node: ^5.2.7 => 5.2.7

Severity

annoyance

Additional Information

The message is not shown in npm:

npm i @sveltejs/adapter-node

# added 75 packages in 14s

# 10 packages are looking for funding
#   run `npm fund` for details
@Conduitry
Copy link
Member

Peculiar. It looks like picomatch is an optional peerdep of fdir - with those ranges of v3 or v4. But v2 is a dependency elsewhere in the tree, and pnpm is using that version instead everywhere, rather than having two different versions in the tree for an optional peerdep. We should look to see whether there are any upgrades possible in the intermediate dependencies that are currently depending on picomatch v2.

@sveltejs/adapter-node 5.2.7
├─┬ @rollup/plugin-commonjs 28.0.0
│ ├─┬ @rollup/pluginutils 5.1.2
│ │ └── picomatch 2.3.1
│ ├─┬ fdir 6.4.0
│ │ └── picomatch 2.3.1 peer
│ └── picomatch 2.3.1
├─┬ @rollup/plugin-json 6.1.0
│ └─┬ @rollup/pluginutils 5.1.2
│   └── picomatch 2.3.1
└─┬ @rollup/plugin-node-resolve 15.3.0
  └─┬ @rollup/pluginutils 5.1.2
    └── picomatch 2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants