Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop 0 padding on time labels less than 10 minutes? #25

Closed
suragch opened this issue Sep 23, 2021 · 5 comments
Closed

Should we drop 0 padding on time labels less than 10 minutes? #25

suragch opened this issue Sep 23, 2021 · 5 comments

Comments

@suragch
Copy link
Owner

suragch commented Sep 23, 2021

This would change the left and right time labels from this:

00:00
03:27

to this:

0:00
3:27

Zero padding for minutes would remain unaffected for hours greater than 0:

1:00:00
1:03:27

This is related to PR #24.

Since this will affect everyone's UI, please leave a comment here regarding your opinion.

@suragch suragch changed the title Should we drop 0 padding on time less than 10 minutes? Should we drop 0 padding on time labels less than 10 minutes? Sep 23, 2021
@ghost
Copy link

ghost commented Sep 23, 2021

Full support on this one. 😉

Just to add on your comment from above.

PR #24 would change the left and right time labels for hours greater than 1 from this:

0:00:00
1:25:16

to this:

0:00
1:25:16

@suragch
Copy link
Owner Author

suragch commented Sep 24, 2021

PR #24 would change the left and right time labels for hours greater than 1 from this:

0:00:00
1:25:16

@giga10 Actually, the original version already didn't include 0 hours.

This is how it looks currently:

00:00
1:25:16

@ghost
Copy link

ghost commented Sep 24, 2021

This is how it looks currently:

00:00
1:25:16

@suragch Hm. Latest version:

Screenshot_20210924-072400~2.png

@suragch
Copy link
Owner Author

suragch commented Sep 24, 2021

@giga10 My mistake! Thank you for correcting me.

@suragch
Copy link
Owner Author

suragch commented Nov 14, 2021

This is updated in release 0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant