Duplicate properties in the meta-data with lombok

[zhanhb]

Get more than one statement in META-INF/spring-configuration-metadata.json when Annotate ConfigurationProperties class with lombok.Getter lombok.Setter

Here is a test project
/~https://github.com/zhanhb/configuration-processor-lombok-test

[AlexFalappa]

I created another testcase showcasing the issue at /~https://github.com/AlexFalappa/spring-boot-testcase2. The problem could not depend on the presence of an inner class.

@zhanhb, from my experiments a workaround is to make sure the lombok dependency in the pom.xml comes after the spring-boot-configuration-processor one.

[bluebilt]

In our STS environment this problem causes a "Save Problem" popup every time an @ConfigurationProperties is modified and saved.

A save participant caused problems. The save participant 'Code Clean Up' caused an exception: java.lang.IndexOutOfBoundsException: Index: 83, Size: 83. See the error log for details.

@AlexFalappa The suggested workaround does not seem to work in our project

[AlexFalappa]

@bluebilt then something more involved is going on in the spring-configuration-processor...

[snicoll]

Looks like Lombok is quite painful in this scenario, see this stackoverflow thread

What happens here is that lombok has already ran and has generated the thing that we are auto-detecting ourselves. So we first create a property because the getter/setter is there and then we check if lombok types are set somewhere (they are). And we generate the property again.

It would be so much easier if we could guarantee that lombok has to run first. That way, all the lombok specific code in our codebase could go away. Unfortunately, that does not seem to be possible.

[snicoll]

@bluebilt please report this issue in the STS tracker. Adding the logs and what you are doing should help.

[AlexFalappa]

@snicoll you may want to have a look at this MapStruct issue where they faced and solved a similar issue.

At this comment one of the lombok developer seem to explain why the annotation processors dependency order in the pom.xml apparently avoids the problem.

After that MapStruct's @gunnarmorling references a SPI made in collaboration with lombok devels to solve the issue.

Hope it helps

[snicoll]

@AlexFalappa thanks. I have a "fix", about to push.