-
Notifications
You must be signed in to change notification settings - Fork 692
Suppress exception in Pub/Sub adapter in AUTO_ACK and MANUAL modes #2319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2319 +/- ##
=========================================
Coverage 73.54% 73.54%
Complexity 2078 2078
=========================================
Files 258 258
Lines 7468 7469 +1
Branches 772 772
=========================================
+ Hits 5492 5493 +1
Misses 1620 1620
Partials 356 356
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add docs to clarify the behavior?
Thanks for getting to the bottom of this complicated issue; I know that users have always periodically posted questions asking about this so it is very helpful to clarify expected behavior.
Yes, I am going to whip #2078 into shape next. |
...springframework/cloud/gcp/autoconfigure/pubsub/it/PubSubChannelAdaptersIntegrationTests.java
Outdated
Show resolved
Hide resolved
...springframework/cloud/gcp/autoconfigure/pubsub/it/PubSubChannelAdaptersIntegrationTests.java
Show resolved
Hide resolved
...springframework/cloud/gcp/autoconfigure/pubsub/it/PubSubChannelAdaptersIntegrationTests.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the at least and at most check! :)
The current behavior of the Pub/Sub Spring Integration inbound adapter throwing an exception in AUTO_ACK and MANUAL modes results in client library reacting to the exception by nacking in its code.
This PR removes the exception and logs a warning instead, allowing the message to be redelivered according to Subscription ackDeadline setting and the client library's automatic deadline extension setting.
Fixes #2250.
Follow-up to #2074.