OkHttpClientHttpRequestFactory prevents usings OkHttp interceptors

[clemp6r]

OkHttpClientHttpRequestFactory uses OkUrlFactory.

With OkHttp 2.2.0 comes a new great feature: Interceptors. Interceptors won't work when using OkUrlFactory, as explained here: /~https://github.com/square/okhttp/wiki/Interceptors

Can you provide a different implementation of OkHttpClientHttpRequestFactory that don't use OkUrlFactory so we can use interceptors?

(FYI http://facebook.github.io/stetho/ needs OkHttp interceptors)

[gmarques33]

I'm also trying to use Stetho with interceptors and I have this problem too.
I'm trying to use StethoURLConnectionManager with a custom ClientHttpRequestFactory, but I can get only request on chrome dev tools.

[WonderCsabo]

Guys, how an other implementation should look like? I assume it cannot be achieved easily.

[royclarkson]

Spring Framework recently included OkHttp support. It can probably be adapted for android.

Sent from my iPad

On Jun 20, 2015, at 07:53, Csaba Kozák notifications@github.com wrote:

Guys, how an other implementation should look like? I assume it could not be achieved easily.

—
Reply to this email directly or view it on GitHub.

[WonderCsabo]

Can you reference the changeset which did that?

[WonderCsabo]

@royclarkson can you point me to the changeset? :)

[WonderCsabo]

Never mind. 😉 Thanks for fixing this!

[royclarkson]

@WonderCsabo I spent some time last night and modified the implementation from Spring Framework. It should be in a good place now.

[royclarkson]

I pushed 2.0.0.M3 with the latest OkHttp support. It's available for testing from the spring repository.

[WonderCsabo]

@royclarkson i am getting this exception:

java.lang.IllegalArgumentException: method POST must have a request body.
    at com.squareup.okhttp.Request$Builder.method(Request.java:244)
    at org.springframework.http.client.OkHttpClientHttpRequest.executeInternal(OkHttpClientHttpRequest.java:85)
    at org.springframework.http.client.AbstractBufferingClientHttpRequest.executeInternal(AbstractBufferingClientHttpRequest.java:48)
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:84)
    at org.springframework.http.client.InterceptingClientHttpRequest$RequestExecution.execute(InterceptingClientHttpRequest.java:91)
    at my.super.secret.package.AuthorizationInterceptor.intercept(AuthorizationInterceptor.java:29)
    at org.springframework.http.client.InterceptingClientHttpRequest$RequestExecution.execute(InterceptingClientHttpRequest.java:81)
    at org.springframework.http.client.InterceptingClientHttpRequest.executeInternal(InterceptingClientHttpRequest.java:67)
    at org.springframework.http.client.AbstractBufferingClientHttpRequest.executeInternal(AbstractBufferingClientHttpRequest.java:48)
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:84)
    at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:536)
    at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:499)
    at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:447)

The same call worked with M2.

[royclarkson]

Hmm. Looks like there was a change in OkHttp 2.4 to require a request body. The dependency was updated from 2.1.0 to 2.4.0 in the M3 release. Would you mind opening a new issue please? We can probably handle this situation.

[WonderCsabo]

@royclarkson i am not sure about that. I was already using OkHttp 2.4 and i experienced no problems with the old OkHttpRequestFactory implementation in M2.

[royclarkson]

M2 was using the UrlConnection API, instead of a proper implementation. That might be why it was still working. I'm guessing at this point.

[WonderCsabo]

Yeah, i know that. :) I opened #25.

[royclarkson]

Heh. Thanks for the reminder. :)