added id3 separator

spotDL · Jan 21, 2023 · a4b54aa · a4b54aa
1 parent 0b13e9b
commit a4b54aa
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 5 deletions.
diff --git a/spotdl/download/downloader.py b/spotdl/download/downloader.py
@@ -659,7 +659,7 @@ def search_and_download(self, song: Song) -> Tuple[Song, Optional[Path]]:
                         Path(file_to_delete).unlink()
 
             try:
-                embed_metadata(output_file, song)
+                embed_metadata(output_file, song, self.settings["id3_separator"])
             except Exception as exception:
                 raise MetadataError(
                     "Failed to embed metadata to the song"

diff --git a/spotdl/download/progress_handler.py b/spotdl/download/progress_handler.py
@@ -344,8 +344,8 @@ def notify_error(
         if finish:
             self.progress = 100
 
-        if logger.level == logging.DEBUG:
-            logger.error(message)
+        if logger.getEffectiveLevel() == logging.DEBUG:
+            logger.exception(message)
         else:
             logger.error("%s: %s", traceback.__class__.__name__, traceback)
 

diff --git a/spotdl/types/options.py b/spotdl/types/options.py
@@ -65,6 +65,7 @@ class DownloaderOptions(TypedDict):
     log_level: str
     simple_tui: bool
     fetch_albums: bool
+    id3_separator: str
 
 
 class WebOptions(TypedDict):
@@ -130,6 +131,7 @@ class DownloaderOptionalOptions(TypedDict, total=False):
     log_level: str
     simple_tui: bool
     fetch_albums: bool
+    id3_separator: str
 
 
 class WebOptionalOptions(TypedDict, total=False):

diff --git a/spotdl/utils/arguments.py b/spotdl/utils/arguments.py
@@ -450,6 +450,13 @@ def parse_output_options(parser: _ArgumentGroup):
         help="Fetch all albums from songs in query",
     )
 
+    # Option to change the id3 separator
+    parser.add_argument(
+        "--id3-separator",
+        type=str,
+        help="Change the separator used in the id3 tags. Only supported for mp3 files.",
+    )
+
 
 def parse_web_options(parser: _ArgumentGroup):
     """

diff --git a/spotdl/utils/config.py b/spotdl/utils/config.py
@@ -256,6 +256,7 @@ def create_settings(
     "log_level": "INFO",
     "simple_tui": False,
     "fetch_albums": False,
+    "id3_separator": "/",
 }
 
 WEB_OPTIONS: WebOptions = {

diff --git a/spotdl/utils/metadata.py b/spotdl/utils/metadata.py
@@ -128,7 +128,7 @@ class MetadataError(Exception):
 LRC_REGEX = re.compile(r"(\[\d{2}:\d{2}.\d{2,3}\])")
 
 
-def embed_metadata(output_file: Path, song: Song):
+def embed_metadata(output_file: Path, song: Song, id3_separator: str = "/"):
     """
     Set ID3 tags for generic files (FLAC, OPUS, OGG)
 
@@ -195,7 +195,10 @@ def embed_metadata(output_file: Path, song: Song):
 
     # Mp3 specific encoding
     if encoding == "mp3":
-        audio_file.save()
+        if id3_separator != "/":
+            audio_file.save(v23_sep=id3_separator, v2_version=3)
+        else:
+            audio_file.save()
 
         audio_file = ID3(str(output_file.resolve()))